[openssl-dev] [openssl.org #4590] accessors without const return arguments

[Roumen Petrov via RT]

Hello,

Recently declaration of a number of get0 methods was changed to return
constant values (BIGNUM).

Lets me quote description of an allocator "/ECDSA_SIG_new()/ allocates a
new *ECDSA_SIG* structure (note: this function also allocates the
BIGNUMs) and initialize it."

Now lets try to write deserialization of a ECDSA signature. With set
method allocated and never user ECDSA members r and s has to be freed
and replaced by new one. As result extra allocation of big numbers
impact performance and increase memory usage.

Above is reason the request to remove const from return argument of get0
methods.

The issue is not only for ECDSA but also for DSA_SIG and RSA, DSA, DH
keys where situation is similar.


Regards,
Roumen Petrov

[Stephen Henson via RT]

Post by Roumen Petrov via RT
Above is reason the request to remove const from return argument of get0
methods.

We had a discussion about this and the preference was to have get methods
retain const for various reasons.

Instead the DSA_SIG/ECDSA_SIG structures now no longer pre-allocate r/s so they
aren't immediately freed when you set them.

Post by Roumen Petrov via RT
The issue is not only for ECDSA but also for DSA_SIG and RSA, DSA, DH
keys where situation is similar.

Do you have some examples of how this affects other structures? For RSA/DSA/DH
keys the fields are NULL initially unless I've missed something.

Steve.
--
Dr Stephen N. Henson. OpenSSL project core developer.
Commercial tech support now available see: http://www.openssl.org

[Stephen Henson via RT]

This has addressed the original issue. If there are any cases for DH/DSA/RSA
you feel need addressing please give details in a new ticket.

Steve.;
--
Dr Stephen N. Henson. OpenSSL project core developer.
Commercial tech support now available see: http://www.openssl.org

[Roumen Petrov via RT]

This post might be inappropriate. Click to display it.